On Thu, 2007-05-24 at 05:55 -0400, Jeff Garzik wrote: > Alan Cox wrote: > > On Thu, May 24, 2007 at 02:02:11AM -0400, Jeff Garzik wrote: > >> Ben's patch got merged because it does not change the status quo. This > > > > Yes it does - Thats PATA and now > > PATA + MMIO so the problem case. > > hmmm, true. I think Jeff is right. I was not completley sure about the 400ns case in ata_pause but I think it's a good idea to use mmio_flush hook there. The only thing that I'm wondering about a bit is that ata_pause so far uses read of altstatus which _is_ a taskfile register. It's my understanding that we should avoid doing so in that case. So my patch will use the new mmio_flush hook instead, however, that means that PIO and SATA controllers will have NULL there, thus no read. We will have to be careful just in case something actually manages to regress because of the loss of that read. (with IDE, anything is possible !) Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
