Re: [PATCH 4/4] bidi support: bidirectional request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
Subject: [PATCH 4/4] bidi support: bidirectional request
Date: Sun, 15 Apr 2007 20:33:28 +0300

> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 645d24b..16a02ee 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -322,6 +322,7 @@ struct request {
>      void *end_io_data;
> 
>      struct request_io_part uni;
> +    struct request_io_part bidi_read;
>  };

Would be more straightforward to have:

struct request_io_part in;
struct request_io_part out;


>  /*
> @@ -600,6 +601,34 @@ static inline struct request_io_part* rq_uni(struct request* req)
>      return &req->uni;
>  }
>
> +static inline struct request_io_part* rq_out(struct request* req)
> +{
> +    WARN_ON_BIDI_FLAG(req);
> +    return &req->uni;
> +}
> +
> +static inline struct request_io_part* rq_in(struct request* req)
> +{
> +    WARN_ON_BIDI_FLAG(req);
> +    if (likely(rq_dma_dir(req) != DMA_BIDIRECTIONAL))
> +        return &req->uni;
> +
> +    if (likely(req->cmd_flags & REQ_BIDI))
> +        return &req->bidi_read;
> +
> +    return &req->uni;
> +}
> +
> +static inline struct request_io_part* rq_io(struct request* req,
> +                                            enum dma_data_direction dir)
> +{
> +    if (dir == DMA_FROM_DEVICE)
> +        return rq_in(req);
> +
> +    WARN_ON( (dir != DMA_TO_DEVICE) && (dir != DMA_NONE) );
> +    return &req->uni;
> +}

static inline struct request_io_part* rq_io(struct request* req)
{
	return (req is WRITE) ? &req->out : &req->in;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux