Sergei Shtylyov wrote:
Mark Lord wrote:
- correct the chipset names (from CMDxxx to PCI-xxx)
Please explain why this rename is a correction.
Because the chips are officially named PCI064[036] and PCI-64[89].
We normally name things with a combination of brand and chip number.
Lots of companies could have chips with PCI in the name,
but the CMD64x designator makes it quite clear what we're dealing with here.
Note that I'm only changing designator in the procfs output, i.e. not
something important to end user.
Err.. in this case, the procfs output *is* there for the end-user.
Using the name printed on the chip, which matches the cmdxxx.c driver name,
is by far the least confusing way to do it here.
In the machines I have here with these chips,
they are clearly labelled as "CMD" and then "PCI646.."
Although I've never seen the chip, I guess that should be logo, not
the name.
Then perhaps you should test the scheme against the real hardware
before patching it.
Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
