> /* Check if the ATA ports are enabled */ > - if ((pcicfg & 3) == 0) > + if (!(pcicfg & 3)) > return -ENODEV; Why - it was much clearer before and matches the logic below more obviously .. > + /* Map IO ports and initialize host accordingly */ > + iomap[0] = devm_ioport_map(&pdev->dev, 0x1F0, 8); > + iomap[1] = devm_ioport_map(&pdev->dev, 0x3F6, 1); > + iomap[2] = devm_ioport_map(&pdev->dev, 0x170, 8); > + iomap[3] = devm_ioport_map(&pdev->dev, 0x376, 1); > + iomap[4] = pcim_iomap(pdev, 2, 0); > > if (!iomap[0] || !iomap[1] || !iomap[2] || !iomap[3] || !iomap[4]) > return -ENOMEM; Need to look at this arguably it should reserve only the ones it uses - but thats an existing bug that wants attention and can be handled now you use the dummy. Acked-by: Alan Cox <alan@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
