> On Wednesday 21 February 2007, Suleiman Souhlal wrote: > > IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for > > IDE V1 and IDE V2. Modern drives will not be able to recover using > > this error handling. The correct thing to do is issue a SRST followed > > by a SET_FEATURES. > > This change looks fine, indeed we are better of using SRST + SET_FEATURES > than IDLE_IMMEDIATE. > > > Signed-off-by: Suleiman Souhlal <suleiman@xxxxxxxxxx> Acked-by: Alan Cox <alan@xxxxxxxxxx> And this is well worth doing - IDLEIMMEDIATE blows the mind of some later drive firmware that doesn't expect to be treated in an IDE v1 manner. Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html