Re: [RFT] sata_promise: intermittent errors bug hunting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mikael Pettersson wrote:
+	if (hp->flags & PDC_FLAG_GEN_II) {
+		/* record ASIC rev */
+		pci_read_config_byte(pdev, PCI_REVISION_ID, &hp->asic_rev);
+
+#if 1
+		/* set cache line size = 1 */
+		pci_read_config_byte(pdev, PCI_CACHE_LINE_SIZE, &tmp);
+		printk("%s: changing pci_cache_line_size from %#02x to 0x01\n",
+		       __FUNCTION__, tmp);
+		pci_write_config_byte(pdev, PCI_CACHE_LINE_SIZE, 0x01);
+#endif


This bit strikes me as somewhat dubious. If this proves to actually fix something, I would start by exporting pci_set_cacheline_size() in drivers/pci/pci.c, using it, and seeing if that helps.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux