Re: sata_nv: cleanup CPB and APRD initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linux Kernel Mailing List wrote:
Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=41949ed5c11a9d6e7af1afd62957d8d1988c803e
Commit:     41949ed5c11a9d6e7af1afd62957d8d1988c803e
Parent:     08af7414786a3f35b686f68ada3de0b202c03d8c
Author:     Robert Hancock <hancockr@xxxxxxx>
AuthorDate: Mon Feb 19 19:02:27 2007 -0600
Committer:  Jeff Garzik <jeff@xxxxxxxxxx>
CommitDate: Wed Feb 21 04:58:19 2007 -0500

    sata_nv: cleanup CPB and APRD initialization
Clean up the initialization of the CPB and APRD structures so that we
    strictly follow the rules for ordering of writes to the CPB flags and
    response flags, and prevent duplicate initialization.
Signed-off-by: Robert Hancock <hancockr@xxxxxxx>
    Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>
---

@@ -1199,6 +1196,8 @@ static void nv_adma_fill_sg(struct ata_queued_cmd *qc, struct nv_adma_cpb *cpb)
 	}
 	if (idx > 5)
 		cpb->next_aprd = cpu_to_le64(((u64)(pp->aprd_dma + NV_ADMA_SGTBL_SZ * qc->tag)));
+	else
+		cpb->next_aprd = cpu_to_le64(0);

Note, there is no need to convert a zero to little endian. There are no bits to swap :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux