Tejun Heo wrote:
Sorry to keep nagging about patch separation and your way could be okay too, but IMHO this can be done better in one of the following ways. 1. Keep two patches. One to break down the interrupt handler the other to improve it. In this case the first one shouldn't introduce major new features but just focus on breaking down existing one. 2. Do it in single patch. It seems the changes are localized enough. Just name it something like 'reimplement irq handler' and list changes in the commit message. After seeing the change, I'm leaning toward #2. Thanks. :-)
These two sata_vsc changes should be done in a single patch. "add new stuff" and "use new stuff" patches can be combined. The types of patches that normally should be separated are logical changes like "clean up irq handling" or "improve EH", changes that can be git-bisect'd usefully.
The changes look OK to me. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
