Linus Torvalds wrote:
On Thu, 15 Feb 2007, Jeff Garzik wrote:
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index db185f3..d51f0f1 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -22,6 +22,7 @@ config IA64
config 64BIT
bool
+ select ATA_NONSTANDARD if ATA
default y
Ok, this is just _strange_.
Agreed.
Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable
may work (well, I _assume_ it does), but it's just psychedelic.
AFAICT it's an attempt to do an unconditional 'select'. I'm /not/
disputing its psychedilic properties, certainly, just figured that was
the way that IA64 arch folks did stuff like this.
How about adding a separate config entry like
config IA64_ATA
bool
depends on ATA
select ATA_NONSTANDARD
default y
which kind of makes sense when you squint just the right way..
Either way, that seems sane to me. I'd love to have some IA64 folks to
comment though.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
