Re: [PATCH][pata] ide: cable detection fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> * use eighty_ninty_three() in ide_ata66_check(), this actually fixes 3 bugs:
>   - bit 13 (word 93 validity check) == 1 and bit 12 (80-wire cable test) == 0
>     configuration was incorrectly treated as a 80-wire cable present

I think you mean bit 14 and bit 13. And for validity you must check bits
14/15 together as 0x01. Code seems to have the bits right not the
comment, but doesn't check bit 15.

You also change the IVB behaviour from assuming drives would set either
the correct bit and/or the valid bit, to drives must always set the
correct bit but not neccessarily valid. It would be nice to know if that
is intentional as the original IVB hack is murky early ATA standard
history and I am not sure what the drive id error in question actually
was ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux