> As I recall, the 31244 and VSC-7174 always send an interrupt, so the > driver should account for this. I thought we had code already in the > driver to handle this, but perhaps recent changes stomped that. > > It would be good to standardize the way we handle these sorts of > controllers, because (I think) Mark Lord has the same problem on > sata_qstor (or pdc_adma?). > > Jeff The error interrupt handling code is still in there and is working. The following patch works for me. --- sata_vsc: handle unexpected interrupts when executing a polled IDENTIFY From: Dan Williams <dan.j.williams@xxxxxxxxx> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> --- drivers/ata/sata_vsc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/ata/sata_vsc.c b/drivers/ata/sata_vsc.c index 0fa1b89..7425d62 100644 --- a/drivers/ata/sata_vsc.c +++ b/drivers/ata/sata_vsc.c @@ -258,7 +258,9 @@ static irqreturn_t vsc_sata_interrupt (int irq, void *dev_instance) /* Clear interrupt status */ ata_chk_status(ap); handled++; - } + } else if (qc->tf.command == ATA_CMD_ID_ATA) + /* 31244 interrupts on polled IDENTIFY commands */ + ata_chk_status(ap); } } } - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
