Alan wrote: > On Mon, 5 Feb 2007 21:47:13 +0900 > Tejun Heo <htejun@xxxxxxxxx> wrote: > >> eighty_ninty_three() had word 93 validitity check but not the 80c bit >> test itself (bit 12). This increases the chance of incorrect wire >> detection especially because host side cable detection is often >> unreliable and we sometimes soley depend on drive side cable >> detection. Fix it. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >> --- >> Ah... thanks. That explains the code much better. Fixed accordingly. >> >> diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c >> index badde63..6558055 100644 >> --- a/drivers/ide/ide-iops.c >> +++ b/drivers/ide/ide-iops.c >> @@ -607,6 +607,8 @@ u8 eighty_ninty_three (ide_drive_t *drive) >> if(!(drive->id->hw_config & 0x4000)) >> return 0; >> #endif /* CONFIG_IDEDMA_IVB */ >> + if (!(drive->id->hw_config & 0x2000)) >> + return 0; >> return 1; > > Acked-by: Alan Cox <alan@xxxxxxxxxx> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
