Alan wrote: >> This patch implements mode_filter for pata_amd which makes it avoid >> configuring udma mode higher than BIOS did. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > NAK, wrong for the same reason as it is wrong on the IDE one, and even > more so as we will support hotplug and the like in time too. Yeap, it's wrong for hotplug but... 1. I don't think PATA hotplug is gonna be popular and even if we get autodetection wrong (slower than optimal, which is way better than faster than possible) on hotplug, we can allow the user to tune it afterwards. 2. We don't have any way to detect cable type reliably on that controller, so getting cable type correctly automatically on hotplug is impossible anyway. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
