> > Yep and if the BIOS programmed the slave into DMA that might not be ideal. > > How so? The bit will be programmed by set_dmamode() right after > set_piomode() is complete. IFF we also put the device into a DMA mode. A blacklisted device would be wrong. > See the difference? Smart one liners are dangerous. ?* is _much_ > better than cryptic arithmetic. Agreed > > >> * MWDMA mode programming cleared udma_mask even when the controller > >> doesn't support UDMA. This doesn't matter for your case. > > > > Or on the actual hardware. > > I was trying to make it more consistent with pio counterpart. We can > remove if() from set_piomode too. Let's just keep things in sync > between stuff including ide piix driver. The one you must not touch is the UDMA register rather than added UDMA bits in older registers. Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
