Tejun Heo wrote:
Both ATA and ATAPI devices used the default timeouts defined by SCSI high level driver. For both disks and ODDs, it was 30secs, which was way too long for disks. This patch makes most ATA commands time out after 7secs - the de facto ATA command timeout, while leaving ATAPI timeout at 30secs.
Good patch, LONG overdue. But 7 seconds is too short. I have drives here now that take slightly more than 7 seconds to report media errors. With this patch, libata will timeout/reset the drive just before it had a chance to tell us why it was taking too long. The result would be that we might lose data unnecessarily, especially in combination with the current SCSI policy of blindly failing the entire request when only one sector was bad. I've used 10 second timeouts with 100% success over the past 14 years, which allows just enough margin (+2) for drives to finish their internal retries and report back. NACK to 7, ACK to 10 seconds. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
