On Thu, 2007-02-01 at 09:33 +0900, Tejun Heo wrote: > I might have missed the discussion but can't we just set > host->max_cmd_len to 16 unconditionally? libata is emulating a SCSI > device anyway and, from SCSI's POV, the situation is that any libata > ATAPI device can do both 12 and 16 byte commands while some of them only > allow allow ATA_16 for 16 byte command. > > Also, it's not like host->max_cmd_len gives any guaranteed protection > against CDB length. Being a 'host' limit, it's set to the highest > number in the host. In that respect, it should be set to 16 too. All > ATA hosts can do 16 byte CDBs. This looks like a much better proposal to me. James - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html