Akira Iguchi wrote:
This is the patch for PATA controller of Celleb. It depends on the previous "add another IRQ calls" patch. Because this driver needs special taskfile accesses, there is a copy of ata_std_softreset(). ata_dev_try_classify() is exported so that it can be used in this function. Signed-off-by: Kou Ishizaki <kou.ishizaki@xxxxxxxxxxxxx> Signed-off-by: Akira Iguchi <akira2.iguchi@xxxxxxxxxxxxx>
The driver looks OK, the only thing I wonder is: can you use the iomap interface to eliminate the rest of the duplicated code?
See Tejun's latest patchset "[PATCHSET] Managed device resources, take #3" which completes the conversion of libata to using the lib/iomap.c interface.
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
