Re: [PATCH] libata: fix compile warning caused by ignoring __must_check results

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 20 Jan 2007 14:23:29 +0900
Tejun Heo <htejun@xxxxxxxxx> wrote:

> Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which
> are caused by throwing away return values marked with __must_check.
> 
> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

NAK NAK NAK NAK NAK NAK

As was previously discussed the bug is the bogus __must_check on
pci_set_mwi. That __must_check should be removed and that was also the
decision before but nothing happened. Please therefore get the pci header
fixed.

>  	pci_set_master(cs5530_0);
> -	pci_set_mwi(cs5530_0);
> +	rc = pci_set_mwi(cs5530_0);
> +	if (rc)
> +		dev_printk(KERN_WARNING, &cs5530_0->dev,
> +			   "WARNING: failed to set MWI\n");

Please drop this patch. Users don't need to scared by this bogus message.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux