Jeff Garzik wrote: > Tejun Heo wrote: >> Some uli controllers have stuck SIMPLEX bit which can't be cleared >> with ata_pci_clear_simplex(), but the controller is capable of doing >> DMAs on both channels simultaneously. Ignore it. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > This is going to be the common case going forward. Please create an > 'ignore simplex bit' flag, and set it in sata_uli I'm a little bit hesitant to do that. 1. I don't think we're gonna have a lot of drivers which need this. Just a few. We've just found one now. 2. I think libata core layer (sff included) is burdened with too much already. Also, now that devres is acked, we can easily transition to alloc - init - register model which gives LLDs much more flexibility and this kind of stuff can easily be done in init_one()'s. It just fits there. But, it's your call. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
