> >>+static int tc86c001_busproc(ide_drive_t *drive, int state) > >>+{ > > > Waste of space having a busproc routine. The maintainer removed all the > > usable hotplug support from old IDE so this might as well be dropped. > > Don't know what you mean, ioctl is still there... You can turn the bus on and off but there is no ability to actually swap drives except in RHEL4 and 2.4.x-ac kernels. Hence "waste of space" > > "Close but no cookie": please fix the PCI quirk to match the current -mm > > behaviour with the ATA resource tree. Otherwise - nice driver. > > Ugh, I should've expected some backstab from -mm tree... If it is native only then there are no problems with the quirk Acked-by: Alan Cox <alan@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html