> Was the duplication of timings[] deliberate? It's actually duplicated in all the PIIX/ICH-alike drivers. I could move it in them all. Jeff - its copied from your piix driver - shall I move them all ? > diff -puN include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy include/linux/pci_ids.h > --- a/include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy > +++ a/include/linux/pci_ids.h > @@ -1622,6 +1622,7 @@ > #define PCI_VENDOR_ID_ITE 0x1283 > #define PCI_DEVICE_ID_ITE_8211 0x8211 > #define PCI_DEVICE_ID_ITE_8212 0x8212 > +#define PCI_DEVICE_ID_ITE_8213 0x8213 Sorry about that one - your guess is 100% correct of course - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html