Mark Lord wrote:
Tejun Heo wrote:
..
+ /* Try to attach new SCSI device. SCSI midlayer
+ * doesn't supply separate interfaces for allocating
+ * and probing, so in this function, we can associate
+ * new SCSI device with its target ATA device only
+ * after probing is complete.
..
I'm not necessarily disagreeing with the code, but rather that comment.
Mmm.. isn't slave_alloc() for allocating? It gets invoked before
the INQUIRY, and then slave_configure() is invoked after a successful
device INQUIRY (otherwise slave_destroy() is invoked to clean up).
Yeah, right. That will be the perfect place to attach ATA device.
Thanks for pointing out. I'll redo this patch.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
