Re: [PATCH] libata: fix scsi_host_template in drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
This patch fixes the followings regarding sht usage in libata drivers.

* sht->max_sectors is overrided unconditionally in ->slave_configure.
  There's no reason to set it to any value.

* Many LLDs are missing sht->slave_destroy.  The method is mandatory
  to support device warm unplugging (echo 1 > /sys/.../delete).
  Without it, libata might access released scsi device.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---

Another candidate for #upstream-fixes.

if you want stuff in #upstream-fixes, you have to cut the patch down to its bare minimum. the max_sectors change in this case is a cleanup.

I ACK the patch, but ask: would you prefer to split the patch, or just this into #upstream?

I'll split.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux