On 11/22/06, Jeremy Higdon <jeremy@xxxxxxx> wrote:
On Tue, Nov 21, 2006 at 05:28:16PM -0800, Andrew Morton wrote:
> On Mon, 20 Nov 2006 19:15:52 -0800
> Jeremy Higdon <jeremy@xxxxxxx> wrote:
>
> > This patch removes a module_exit function that it sgiioc4 should not have had.
> >
> > Signed-off-by: Jeremy Higdon <jeremy@xxxxxxx>
> >
> >
> > --- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
> > +++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
> > @@ -768,14 +768,7 @@
> > return ioc4_register_submodule(&ioc4_ide_submodule);
> > }
> >
> > -static void __devexit
> > -ioc4_ide_exit(void)
> > -{
> > - ioc4_unregister_submodule(&ioc4_ide_submodule);
> > -}
> > -
> > late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
> > -module_exit(ioc4_ide_exit);
> >
> > MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
> > MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
>
> Why? We'd prefer that the module be unloadable, wouldn't we?
not supported in the current IDE layer model
(lack of dynamic allocation for ide_hwifs[] and some needed locking)
It seems that the IDE layer doesn't support that. sgiioc4 was the only
driver in drivers/ide/pci that had an exit function. After an unload,
the devices would stay around and the next attempt to reference would
crash...
ack
Andrew, please apply.
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
