Tejun Heo wrote:
First of all, that function is moved verbatim from ata_scsi_rw_xlat(),
Yeah, I knew that. Don't mind me, I'm just have a bit of a scatterbrain day, switching back and forth between reviewing patches, and deep thinking about another task. For some odd reason I thought "lba_48_ok" checked whether or not a drive could do LBA48.. probably because I have a routine by that exact name in several drivers of my own coding. But of course it's different here: it's just checking the requested block against the LBA48 range. But is this even necessary here? Presumably we already checked the block number against the device max before getting to this point? Or did we? I don't actually see that code nearby, but perhaps the SCSI mid-layer did it for us? If not, *where* do we have that check? Anyway, it will all work as is. I'm just wondering if we can nuke a few lines or not. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
