Tejun, Jeff, In an attempt to enable suspend-to-ram (and correct resume) for NVidia MCP51 PATA device, I added .suspend = ata_pci_device_suspend, .resume = ata_pci_device_resume, To amd_pci_driver struct. With this, first attempt to suspend results in an error (-16 "device is still active"), and second attempt leads to oops. Do you want to see console output and lspci for this? Leaving .suspend = NULL and adding only .resume = ata_pci_device_resume, seems to reset the device properly and work fine. Before this was enabled, the box would suspend/resume fine than hang silently about 30 seconds after resume. -----Original Message----- From: Alan Cox [mailto:alan@xxxxxxxxxx] Sent: November 8, 2006 11:07 AM To: Andrei Tanas Cc: 'Alan Cox' Subject: Re: pata_amd.c version 0.2.4 On Wed, Nov 08, 2006 at 09:35:20AM -0500, Andrei Tanas wrote: > Adding .resume helped - the controller (MCP51) resets properly. Trying to > add .suspend resulted in an error (-16, "device is still active"), with > subsequent oops on the next suspend attempt. Let me know if you want console > output and lspci for this. I don't really have time to look at it this year, Tejun and Jeff may well be interested - is that the device you were suspending too ? - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html