Luugi Marsan wrote:
From: conke.hu@xxxxxxx There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue. Signed-off-by: Luugi Marsan <luugi.marsan@xxxxxxx>
ACK technical content, but it needs one revision: like someone else (Alan or Tejun?) mentioned, this patch should be revised to use a separate ata_port_operations for the affected chip(s).
Copy ahci_ops to sb600_ops, add your check-atapi-dma function without the vendor/device ID check. Move the vendor/device check to the pci_device_id table by creating a board_ahci_sb600 constant and associated table data.
I agree with other posters that we should move the revision check to more generic code, but such a move should not block this patch. The two efforts can occur in parallel.
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
