Re: [PATCH 2/2 #upstream] ahci: honor PORTS_IMPL on ICH8s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 02, 2006 at 12:20:59PM +0900, Tejun Heo wrote:
> @@ -1439,7 +1453,7 @@ static int ahci_host_init(struct ata_pro
>  	struct ahci_host_priv *hpriv = probe_ent->private_data;
>  	struct pci_dev *pdev = to_pci_dev(probe_ent->dev);
>  	void __iomem *mmio = probe_ent->mmio_base;
> -	unsigned int i, using_dac;
> +	unsigned int i, cap_n_ports, using_dac;
>  	int rc;
>  
>  	rc = ahci_reset_controller(mmio, pdev);
> @@ -1448,10 +1462,34 @@ static int ahci_host_init(struct ata_pro
>  
>  	hpriv->cap = readl(mmio + HOST_CAP);
>  	hpriv->port_map = readl(mmio + HOST_PORTS_IMPL);
> -	probe_ent->n_ports = ahci_nr_ports(hpriv->cap);
> +	cap_n_ports = ahci_nr_ports(hpriv->cap);
>  
>  	VPRINTK("cap 0x%x  port_map 0x%x  n_ports %d\n",
> -		hpriv->cap, hpriv->port_map, probe_ent->n_ports);
> +		hpriv->cap, hpriv->port_map, n_ports);
n_ports is undefined here. Should be cap_n_ports instead.

Other than that, the two patches work perfectly.

-- 
Robin Hugh Johnson
E-Mail     : robbat2@xxxxxxxxxx
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

Attachment: pgpTpvnLXYqvZ.pgp
Description: PGP signature


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux