Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
* move common flags into PIIX_PATA_FLAGS and PIIX_SATA_FLAGS
* kill unnecessary ATA_FLAG_SRST
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
AFAICS, SRST is quite necessary on PATA. What's going on? There
isn't much of any explanation for the SRST removal here :/
Both reset flags ATA_FLAG_SATA_RESET and ATA_FLAG_SRST are used to tell
old EH how to reset and probe the port. In new EH, those flags don't
play any role. What method to use and in what sequence is upto
->error_handler() now. For PATA piix, it only implements SRST, so
that's gonna be used. For SATA piix, ata_bmdma_drive_eh() always
prefers SRST on boot probe.
Once sata_promise/mv/.. are converted to new EH, the above two reset
flags can be removed.
Ah, duh. I knew that, thanks for the clue-hammer :)
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
