Re: [RFT PATCH] libata: implement ATA_FLAG_SETXFER_POLLING and use it in pata_via

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



matthieu castet wrote:
Hi,

Sorry for the delay.

Tejun Heo wrote:

This patch implements ATA_FLAG_SETXFER_POLLING and use in pata_via.
If this flag is set, transfer mode setting performed by polling not by
interrupt.  This should help those controllers which raise interrupt
before the command is actually complete on SETXFER.

Rationale for this approach.

* uses existing facility and relatively simple
* no busy sleep in the interrupt handler
* updating drivers is easy

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---

Matthieu Castet, can you please test this patch?  It's against
libata-dev#upstream, but -mm might work too.  If you want a patch
against -mm, just let me know.


With the attached patch against 19-rc1-mm1 (I had to remove pata irq handler), it seems to work (see the attached log).
					      * polling IDENTIFY */
+	ATA_FLAG_SETXFER_POLLING= (1 << 14), /* use polling for SETXFER */
opps i forgot to change ATA_FLAG_SETXFER_POLLING to ATA_FLAG_SETXFER_POLLING (1<<15).

I suppose I need to retest that ?


Matthieu
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux