On Thu, 28 Sep 2006 10:38:29 +0200 Hannes Reinecke <hare@xxxxxxx> wrote: > Hi Jeff, > > argl. Appearently I'm in Yeltsin mode. > > Anyway: I'm also have finished an updated version of the ACPI patches. > They are also based upon the patches by Randy Dunlap but with some > improvements: Hey, I don't care who gets this stuff in, I just want it done with :). I'm going to go ahead and make the changes to my patches that Jeff suggested yesterday, but I'm also glad to help review your patches. But having looked at your attachment I feel like I'm missing something. Was there more than this? I don't see the patch that has libata-acpi.c in it. > > - Omit the namespace walk for SATA devices. We can really trust the ACPI > layer to find out the correct device. If not the ACPI is buggered anyway > and we shouldn't even try to continue. Not sure about this one - how does this work for devices that may not be present at boot time? Normally this is something we have to walk namespace for in order to discover -- at least with removable bay devices. > - Make the control over the ACPI execution more finegrained as some > methods (most notably _GTF) are downright disastrous on PATA devices, > whereas you really want to call _GTM / _STM on these to have them > properly resumed after suspend to RAM. > - Only export the symbols we really have to :-) > - Proper integration with the new EH code. This is actually an error in > the patch by Kristen; for new-style EH the ACPI functions will never be > called :-( > > If you consider this a duplicate I'm happy to rebase my patch on top of > Kristens. > > Comments etc are welcome. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke hare@xxxxxxx > SuSE Linux Products GmbH S390 & zSeries > Maxfeldstraße 5 +49 911 74053 688 > 90409 Nürnberg http://www.suse.de > - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
