Tejun Heo wrote:
Jeff Garzik wrote:
+ /* iomap PCI BARs */
+ for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+ if (!(bar_mask & (1 << i)))
+ continue;
NAK, you only should map the stuff you are going to use.
Mapped resources is finite, and you definitely don't want to map
certain resources on certain controllers -- sometimes they are a
memory area that's too large to be mapped, even.
Yeap, that's what @bar_mask and the above if () continue; block is for.
Or am I misunderstanding you?
Oops, I missed that part. Ignore my comment...
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
