On Thu, Sep 14, 2006 at 03:40:55PM -0700, Darrick J. Wong wrote: > Jeff Garzik wrote: > > > I disagree completely with this approach. > > > > You don't need a table of hooks for the case where libata is disabled in > > .config. Thus, it's only useful for the case where libsas is loaded as > > a module, but libata is not. > > Indeed, I misunderstood what James Bottomley wanted, so I reworked the > patch. It has the same functionality as before, but this module uses > the module loader/symbol resolver for all the functions in libata, and > allows libsas to (optionally) call into sas_ata with weak references by > pushing a table of the necessary function pointers into libsas at > sas_ata load time. Thus, libsas doesn't need to load libata/sas_ata > unless it actually finds a SATA device. NACK again. Week references are bad. Please change it back to normal hard references so that it works like everything else in the kernel. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html