Hello, Arnaud Patard wrote:
0100-01fe : pnp 00:09 0170-0177 : libata 01f0-01f7 : libata
Arghh... [--snip--]
Index: linux-2.6/drivers/scsi/libata-bmdma.c =================================================================== --- linux-2.6.orig/drivers/scsi/libata-bmdma.c +++ linux-2.6/drivers/scsi/libata-bmdma.c @@ -1016,10 +1016,13 @@ int ata_pci_init_one (struct pci_dev *pd res.start = 0x1f0; res.end = 0x1f0 + 8 - 1; conflict = ____request_resource(&ioport_resource, &res); + if (conflict->child) + conflict = ____request_resource(conflict,&res);
IMHO, having something which is slightly more generic would be better - e.g. looping till no child.
if (!strcmp(conflict->name, "libata")) legacy_mode |= (1 << 0); else { disable_dev_on_err = 0; + printk(KERN_WARNING "ata: conflict with %s\n",conflict->name); printk(KERN_WARNING "ata: 0x1f0 IDE port busy\n");
Please merge two printks into one. Other than that, I think printing conflict name is nice addition.
} } else
Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html