Re: [PATCH 1/20] libata: kill ata_host_stop()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
As all the current LLDs are PCI, ata_pci_host_stop() should be used,
which BTW is effectively identical to ata_host_stop().  Convert all
LLDs to use ata_pci_host_stop() and kill ata_host_stop().

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

This patch is broken because now several drivers which do not do

    mmio_base = pci_iomap()

now unconditionally call pci_iounmap().

I thought pci_iounmap() allowed NULL input. i386 and x86_64 look safe but NULL arg doesn't seem to be supported explicitly. I'll add 'if (host->mmio_base)' to ata_pci_host_stop().

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux