Jeff Garzik wrote:
This is definitely the wrong direction.
Ouch... The whole patch?
We don't want to keep crowding knowledge of multiple bus technologies
into the same function.
Do you mean PCI-IDE (legacy/BMDMA), PCI-native and newer controllers
(including MSI stuff)? Bus-wise they're all PCI.
ata_pci_request_irq() and other code above follows the same theme... but
its an unmaintainable direction.
This sort of stuff needs to be split up, not coalesced.
ata_pci_*() functions are PCI helpers and I wanted to move most of PCI
resource bookkeeping into helpers. Less clutter in LLDs and less errors.
Another thing to think about: IMO it makes sense to separate out the
PCI IDE resource handling, because that set of technology is largely
static.
>
Most newer controllers will only have a few resources, normally MMIO,
and may even support MSI-X (multiple messages for different event types,
rather than a single message for all events like MSI).
So, I'd like to see some of this inside libata-bmdma.c to keep the core
free of such nastiness.
I'm having a little bit difficult time following what you're thinking.
Whatever the final interface is, the goals would be similar to what's
listed in the head message of this patchset, and I think
alloc/init/attach model is a good way to achieve that thus killing
probe_ent. Can you explain in more detail how the interface should look
like?
Thanks.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
