Tejun Heo wrote:
> Mark Lord wrote:
>
>>
>> Is this "IDENTIFY using IRQs rather than polling" a newish feature?
>> Because I just don't see how it could work with the the existing
>> adma_intr_mmio routine --> that code is only correct for non-data
>> commands, and IDENTIFY definitely has data.
>
>
> IDENTIFY w/ IRQs came with Albert Lee's irq-pio which was merged into
> mainline together with new EH.
>
Oops, pdc_adma.c was overlooked by the irq-pio patch.
Only HSM_ST_LAST interrupts should be delivered to this LLDD.
Could you please check if the attached patch helps?
--
albert
(Patch against mainline 2.6.18-rc4.)
--- linux-2.6.18-rc4/drivers/scsi/pdc_adma.c 2006-08-08 14:03:21.000000000 +0800
+++ linux-2.6.18-rc4-adma-poll/drivers/scsi/pdc_adma.c 2006-08-08 14:05:13.000000000 +0800
@@ -183,7 +183,8 @@ static struct ata_port_info adma_port_in
{
.sht = &adma_ata_sht,
.host_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST |
- ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO,
+ ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO |
+ ATA_FLAG_PIO_POLLING,
.pio_mask = 0x10, /* pio4 */
.udma_mask = 0x1f, /* udma0-4 */
.port_ops = &adma_ata_ops,
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
