On Wed, 19 Jul 2006 22:19:29 -0700 Jeremy Higdon <jeremy@xxxxxxx> wrote: > On Wed, Jul 19, 2006 at 10:31:55AM -0500, John Keller wrote: > > Resend #2 changes include: > > > > - use 'void __iomem *' for ioremap() return values, > > and handle error cases. > > > > sgiioc4.c had been recently converted to using mmio ops. > > There are still a few issues to cleanup. > > > > Signed-off-by: jpk@xxxxxxx > Signed-off-by: jeremy@xxxxxxx hrm. I think we're owed a couple of iounmap()s, please. One in the ide_dma_sgiioc4() error path and one in the takedown path. Maybe that was one of the "few issues to cleanup", but it's a pretty simple one. - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
