On Wed, Jul 19 2006, Jeff Garzik wrote: > Tejun Heo wrote: > >Implement powersave timer. It is primarily for OS-driven HIPS > >implementation but can be used for any other PS purpose LLD sees fit. > >During normal operation, PS timer is automatically started with > >timeout ap->ps_timeout on port idle and stopped when the port becomes > >busy. The timer is also stopped while EH. > > > >To minimize overhead and allow easy implementation of expected > >operation model, ata_ps_timer_worker() is used as timer callback which > >invokes LLD supplied ap->ps_timer_fn() if condition meets and also > >helps implementing sequenced multi-step operation. > > > >Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > This makes me wonder what Jens thinks about having a device idle timer > and callback at the block level? At the very least, this feels like it > should be implemented in the SCSI layer, or somewhere other than libata. Since this will be used only when the device is idle, we can reuse the unplug timer and get it pretty much for free. So I think that's a good idea. -- Jens Axboe - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
