On Fri, Jun 30, 2006 at 03:09:16AM +0900, Tejun Heo wrote:
> Please make
>
> + ATA_MSG_ERR = 0,
> + ATA_MSG_WARN = 1,
> + ATA_MSG_DRV = 2,
> + ATA_MSG_INFO = 3, /* revalidation messages, EH progress */
> + ATA_MSG_VDEBUG = 4, /* verbose hot path */
> + ATA_MSG_CMD = 5, /* issue / completion */
> + ATA_MSG_SG = 6, /* SG map/unmap handling */
> + ATA_MSG_TRACE = 7, /* function tracing, e.g. enter/exit */
>
> And test for msg_enable & (1 << (lv)). Otherwise the array will be
> unnecessarily large.
Yeah, but this won't work:
imagine default level is:
msg_enable = ATA_MSG_INFO;
which, if done with subsequent numbers will yield 3 decimal and 0011 binary.
So if i do (1 << lv) and level is currently ATA_MSG_INFO = 3, it will
be decimal 4, and binary 0100. My msg_enable level is 0011 binary so if I do
msg_enable & (1 << lv) it will end up doing 0100 & 0011 and this is 0 although the
message levels are both INFO. In other words, with ATA_MSG_* I need the single
bits set and not consecutive numbers for the unary-and test.
Regards,
Boris.
___________________________________________________________
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
