On Fri, Jun 30, 2006 at 01:27:30AM +0900, Tejun Heo wrote:
<snip>
> >@@ -805,11 +807,16 @@ extern void ata_do_eh(struct ata_port *a
> > /*
> > * printk helpers
> > */
> >-#define ata_port_printk(ap, lv, fmt, args...) \
> >- printk(lv"ata%u: "fmt, (ap)->id , ##args)
> >+#define ata_port_printk(ap, lv, fmt, args...) do { \
> >+ if (unlikely((ap)->msg_enable & (0xFF & (lv)))) \
> ^^^^why?
Because the decimal value of ATA_MSG_TRACE, for example, is 128 (hex 0x80) and
when i shift a 1 128 time to the left, the datatype, in our case an int, i
think (dunno what gcc does exactly here) is too small for the shift. Besides,
ap->msg_enable is an u32 so that if would never be true for something bigger
than 0x20.
> >+ printk("%sata%u: "fmt, __ata_msg_lvs[lv], (ap)->id ,
> >##args); \
> >+} while (0)
> >
> >-#define ata_dev_printk(dev, lv, fmt, args...) \
> >- printk(lv"ata%u.%02u: "fmt, (dev)->ap->id, (dev)->devno , ##args)
> >+#define ata_dev_printk(dev, lv, fmt, args...) do { \
> >+ if (unlikely((dev->ap)->msg_enable & (0xFF & (lv)))) \
> ^^^^ditto
>
> >+ printk("%sata%u.%02u: "fmt, __ata_msg_lvs[lv], \
> >+ (dev)->ap->id, (dev)->devno , ##args); \
> >+} while (0)
> >
> > /*
> > * ata_eh_info helpers
> >@@ -997,9 +1004,8 @@ static inline u8 ata_wait_idle(struct at
> >
> > if (status & (ATA_BUSY | ATA_DRQ)) {
> > unsigned long l = ap->ioaddr.status_addr;
> >- if (ata_msg_warn(ap))
> >- printk(KERN_WARNING "ATA: abnormal status 0x%X on
> >port 0x%lX\n",
> >- status, l);
> >+ ata_port_printk(ap, ATA_MSG_WARN,
> >+ "ATA: abnormal status 0x%X on port 0x%lX\n", status,
> >l);
> ^^^^^ you can drop the header.
will do.
Regards,
Boris.
___________________________________________________________
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
