Tejun Heo wrote:
Convert sata_via to new EH. vt6420 used ATA_FLAG_SRST while vt6421 used ATA_FLAG_SATA_RESET. This difference seems to be an accident rather than intended. This patch makes both flavors use ata_bmdma_error_handler() which makes use of both SRST and SATA hardreset. This behavior change is intended and if it breaks anything, it should be very easy to spot. Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
Applied. Addressing the "rather than intended" comment above, the history is actually this:
Throughout libata, I have always preferred SATA PHY reset to SRST. SATA_RESET didn't work well on one VTxxxx chip, while it did work on another. Thus, the driver reflected what worked.
While we may need to disable COMRESET completely on vt6420 (look for sata_via bug reports here!), I would prefer to shove both chips down the EH path that you have presented. If that doesn't work, we'll take further action from here.
Jeff - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
