zhao, forrest wrote:
On Mon, 2006-06-19 at 18:27 +0900, Tejun Heo wrote:
Note that per-dev actions
can still be specified at port-level and it has the same effect of
specifying the action for all devices on the port.
Why not use eh_info->action for port-level only, and eh_info->dev_action
[] for device-level only?
From my understanding, this clear separation can at least make code easy
to read.
The distinction between port-wide (later it becomes link-wide) and
device-wide EH operations is meaningful only for PATA devices. For a
SATA LLD, device-wide operations is port-wide operation and using
different fields doesn't make much sense.
So, I chose to put a bit more complexity where those per-dev actions are
implemented while allowing LLDs and other parts of EH not to distinguish
between those two unless it specifically wants to.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
