Jeff Garzik wrote:
Tejun Heo wrote:
As EDD support is removed, a LLD must implement either SRST or SATA
reset. ATA_FLAG_SATA_RESET is enough to represent which one a LLD
implements. Kill ATA_FLAG_SRST.
Note that both flags are already marked obsolete. ATA_FLAG_SATA_RESET
will be removed too once all LLDs are converted to new probing
mechanism. This partial removal is to make room for a new flag needed
for new PM.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
NAK. This will break too many drivers right now (e.g. even more in the
#pata-drivers branch).
My suggestion would be to create a patch that converts as many LLDDs as
you can to the new probing/EH. Ripping through the bmdma+PHY style
controllers should be easy, for example.
Additionally, I would appreciate it if you would patch the #pata-drivers
branch (in a separate patch), if you make a change across all libata
LLDDs. Otherwise the pata-drivers branch will _rapidly_ fall behind,
which is something that I don't want to happen.
Okay, will do that. But, for now, I'll post PM patches above these two
patches for review purpose.
Finally, please update Documentation/DocBook/libata.tmpl, at least for
the ata_port_operations changes made by you. I can work on updating the
EH and other sections myself, if you still dislike DocBook :) But I
really want the libata driver API reference to stay current. (Alan
grumbled at me about this, which I agree)
Agreed. I still don't like DocBook :p but will update it.
As to when, I don't think I can get to it very soon. A lot of things on
todo list and doc update tends to get low priority. Also, I want to
update API doc after BMDMA separation as that will shake things quite a bit.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
