Tejun Heo wrote:
SIEN on some 3112 controllers doesn't mask SATA IRQ properly. IRQ
stays asserted even after SIEN is masked and IRQ is acked. Also, even
while frozen, any SATA PHY event including hardreset raises SATA IRQ.
Clearing SError seems to be the only way to deassert SATA IRQ.
This patch makes sil_host_intr() clear SError on SATA IRQs and ignore
SATA IRQs reported while frozen so that hardreset doesn't trigger
hotplug event (which ends up hardresetting again).
In such cases, the port still gets re-frozen to minimize the danger of
screaming interrupts. This results in one nil EH repeat on
controllers with broken SIEN but other than that does no harm.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---
Here's the revised version. The PCMCIA 3112 controller simply cannot
mask SATA IRQs w/ SIEN. I've tested it w/ discrete 3112 and 3114
cards and the PCMCIA one. All work fine with this patch applied.
Applied.
Note that it is helpful to read the FreeBSD 311x driver, to see what
error handling they use. It seems like they reset the chip much more
frequently than we do.
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
