zhao, forrest wrote:
OK. I ported it to latest #upstream
Signed-off-by: Zhao, Forrest <forrest.zhao@xxxxxxxxx>
Patch content looks OK, but
1) "OK. I ported it to latest #upstream" is not a good description :) I
use the git-applymbox script to apply the patch, and the full technical
patch description is copied from your email's message body directly into
the Linux kernel changelog.
The appropriate place for comments like "OK. I ported it to latest
#upstream" is following the "---" description terminator line. See
Tejun's patches for an example :)
2) Both git-applymbox(1) and patch(1) fail to apply the patch:
[jgarzik@pretzel libata-dev]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command'
fatal: corrupt patch at line 84
[jgarzik@pretzel libata-dev]$ patch -sp1 < /g/tmp/mbox
patch: **** malformed patch at line 144: *args,
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
