Hello, I wrote:
Hello. I'm submitting, mainly for review (questions, comments, etc) the IDE driver for the MIPS-based Toshiba RBTX4939. In some private emails with Bartlomiej about the ide-dma changes, I understand there's at least one problem with the driver (happy to fix with a pointer to a good example). And I see real quickly there's a few style things a Lindent'ing would fix. Thanks.
Signed-off-by: Hiroshi DOYU <hdoyu@xxxxxxxxxx> Signed-off-by: Tom Rini <trini@xxxxxxxxxxxxxxxxxxx>
Index: linux-2.6.10/drivers/ide/ide-cd.c =================================================================== --- linux-2.6.10.orig/drivers/ide/ide-cd.c +++ linux-2.6.10/drivers/ide/ide-cd.c @@ -678,6 +678,13 @@ static int cdrom_decode_status(ide_drive err = HWIF(drive)->INB(IDE_ERROR_REG); sense_key = err >> 4; +#if defined(CONFIG_BLK_DEV_IDE_TX4939) + if (IS_IDE_TX4939) { + extern void tx4939_ide_softreset(ide_drive_t*); + tx4939_ide_softreset(drive); + } +#endif +
Why is this needed?
The datasheet says only about the DMA transfer being stopped by a bus error case. So, who knows? I'm afraid, even Toshiba engineers don't... :-)
Index: linux-2.6.10/drivers/ide/mips/ide-tx4939.c =================================================================== --- /dev/null +++ linux-2.6.10/drivers/ide/mips/ide-tx4939.c
+ sc_port = (!is_slave) ? + data_port + TX4939_ATA_SYSTEM_CONTROL1_OFFSET : + data_port + TX4939_ATA_SYSTEM_CONTROL2_OFFSET; + + if (!hwif->channel) { /* primary */
Why only primary channel is tuned?
You won't believe: it's single channel, and that's how Toshiba deals with this. :-)
Worse, it's dual channel. Then I have no idea other than that this was copied from another driver for the single-channel chip (I've seen such code already). Oh, horror... :-/
Worse still: this controller has only _one_ timing register for both master and slave, and doesn't define selectproc!
BTW, the datasheet is contradictory here. The register map has 2 system control regs per channel, while ATAP setcion says about the single one, and warns that it must be changed with every change of DEV bit...
Though wait, they prefer to handle this in tx4939_ide_outb(). The driver seems even more broken-minded than I initially thought... And that tuneproc() stupidity where they're clearing the DMA mode...
Well, this is not as stupid, DMA mode should be off anyway... MBR, Sergei - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
