Albert Lee wrote:
Normally 0x50 is seen with normal completion, not 0x40.
I'm okay either way. One of my drives reports 0x40 for normal status, so it's where 0x40 came from.
Do we really have to fake qc->result_tf here? Maybe just keep it zero or garbage is good enough: if err_mask == 0 and ATA_QCFLAG_RESULT_TF is not set, qc->result_tf shouldn't be used anyway.
Hmmm... Right. I thought libata SCSI completion path checks TF status unconditionally and added the code. Maybe I was confused. I cannot find the offending part now. Hmmm... I seem to recollect I met a spurious error due to garbage inside qc->result_tf and added the code to initialize it. I'll keep looking.
-- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
