On Wed, May 17 2006, Jeff Garzik wrote: > Jens Axboe wrote: > >I think Hugh traced it down to a unrelated timer change. The above > >really wants to wait for BUSY clear, perhaps the best solution would be > >to have piix device its own ata_piix_device_resume() that first waits > >for BUSY clear, then calls ata_device_resume(). > > Close... all devices should wait for libata to signal that the bus is > ready to be talked to. For some that's waiting for BSY to clear, for > others that's checking the SATA bus. Ok, I meant for the ata_piix case. Same should apply to others, right? Do whatever you need to do to make sure the hardware is ready, then call the generic ata_device_resume() helper to handle the libata side of things. -- Jens Axboe - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
