Alan Cox wrote: >> little bit more complex (it has more moving parts) and it would be >> difficult to define/tune speed down or any other error handling (say, >> turning off NCQ) criteria. But, I might be planning too much. > > The log problem is that you can get 32 errors very fast (doesn't take > much with multiple outstanding commands) The current EH implementation records one error per EH run. It just combines all failed commands and record it as single entry. As each EH run usually takes at least several seconds, 32 slots should give several minutes worth of history even if things are pretty bad. > so you have to choose which > info to throw away - the history or the detail in the commands Yeap. And I also agree that ering is pretty inefficient way to spend 512 bytes of memory. -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
